Skip to content

Refactor the CMake and related scripts for unit tests #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 4, 2025
Merged

Refactor the CMake and related scripts for unit tests #4605

merged 12 commits into from
Nov 4, 2025

Conversation

@lum1n0us
Copy link
Collaborator

@lum1n0us lum1n0us commented Sep 8, 2025 •
edited
Loading

  • Improve the installation of 32-bit dependencies
  • output when unit test cases failed
  • Although the code coverage script works well on Ubuntu 22.04 (gcc11), it encountered several issues(bypassing by --ignore-errors) on Ubuntu 24.04 (gcc13). Add a warning to notice that.
  • Perform some refactoring to address these issues and create a lightweight template.
    • Only unit/CMakeLists.txt fetches googletest.
    • Find LLVM from the case on demand. unit_common.cmake prepares the LLVM_DIR in case config_common.cmake only does it when JIT is enabled.
    • Use WAMR_RUNTIME_LIB_SOURCE to replace a long list.
    • No global compilation flags in unit; each case identifies compilation flags for its unique test plan.
    • Standardize wasm-app compilation scripts. Use ExternalProject and the wasi-sdk toolchain file.
  • In test_warm.sh, run the unit test once instead of multiple times with different running modes, which is actually unnecessary.
  • Remove an incorrect mock from wasm_runtime_common_test.cc.

@lum1n0us lum1n0us force-pushed the fix/unit_coverage branch 3 times, most recently from 808a5d3 to 180b642 Compare September 8, 2025 23:36
@lum1n0us lum1n0us changed the title streamline CMake configurations and improve code coverage collection streamline CMake configurations Sep 9, 2025
@lum1n0us lum1n0us force-pushed the fix/unit_coverage branch 3 times, most recently from 02d19d7 to dd3bf40 Compare September 10, 2025 04:58
@lum1n0us lum1n0us mentioned this pull request Sep 14, 2025
Open
@lum1n0us lum1n0us changed the title streamline CMake configurations streamline CMake configurations in unit tests Sep 21, 2025
@lum1n0us lum1n0us changed the title streamline CMake configurations in unit tests Refactor the CMake and related scripts for unit tests Sep 24, 2025
@lum1n0us lum1n0us marked this pull request as ready for review September 25, 2025 03:02
TianlongLiang
TianlongLiang reviewed Oct 30, 2025
View reviewed changes
lum1n0us added 11 commits November 3, 2025 00:19
@lum1n0us
refactor: streamline CMake configurations and improve code coverage c…
dac49c6 
…ollection

- only unit/CMakeLists.txt fetches googletest
- only unit/unit_common.cmake find LLVM dependencies
- use `WAMR_RUNTIME_LIB_SOURCE` to replace a long list
@lum1n0us
refactor: enable LLVM support across various CMake configurations
9162293
@lum1n0us
fix: remove redundant LLVM dependency installation and add i386 suppo…
387e101 
…rt for libraries
@lum1n0us
refactor: enhance CMake configurations for better build output and mo…
be9ba54 
…dule support
@lum1n0us
remove few wrong mocks from wasm_runtime_common_test_suite
00ef7fb
@lum1n0us
refactor: update CMake configurations for custom section tests and wa…
5cdd77f 
…sm-apps build process
@lum1n0us
fix several reviewing comments
1e212d3
@lum1n0us
Find llvm on demand
ad6e96b
@lum1n0us
refactor: remove verbose flag from build command in CMakeLists.txt
acac1ba
@lum1n0us
add guidelines for creating a test suite in WAMR
ab9ddd6
@lum1n0us
Roll back the previously removed code
5e542ad
TianlongLiang
TianlongLiang previously approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment

@lum1n0us lum1n0us merged commit de4b950 into bytecodealliance:main Nov 4, 2025
463 checks passed
@lum1n0us lum1n0us deleted the fix/unit_coverage branch November 4, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TianlongLiang TianlongLiang TianlongLiang approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lum1n0us @TianlongLiang