Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uninit buffer ancillary APIs #1108

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add uninit buffer ancillary APIs #1108

wants to merge 1 commit into from

Conversation

SUPERCILEX
Copy link
Contributor

Pretty sure I managed to maintain backcompat via a conversion trait.

Closes #1103

@SUPERCILEX
Copy link
Contributor Author

Nevermind, I don't think backcompat is possible without implementing a trait for both DerefMut<Target=[u8]> and DerefMut<Target=[MaybeUninit<u8>]> which I don't think you can do. Targeting the staging branch instead.

@SUPERCILEX SUPERCILEX changed the base branch from main to 1.0-staging August 15, 2024 02:08
@SUPERCILEX
Copy link
Contributor Author

Staging needs a rebase and also #1107

@SUPERCILEX SUPERCILEX changed the base branch from 1.0-staging to main August 15, 2024 03:24
@SUPERCILEX
Copy link
Contributor Author

Annnnnd I decided to make it backwards compatible again. The public API should be identical except there's now a From impl for MaybeUninit. 1.0 should break the ::new impl to take uninits instead.

@SUPERCILEX
Copy link
Contributor Author

Not sure why the tests are so borked.

@SUPERCILEX SUPERCILEX changed the title Make all ancillary APIs use uninit buffers Add uninit buffer ancillary APIs Aug 15, 2024
@SUPERCILEX
Copy link
Contributor Author

Ok so the idea with this one is that the ::new methods would be swapped to use MaybeUninits for 1.0 and any way to construct a buffer with [u8] would be removed. I'm not really happy with the deprecation story as it feels like we'll just be springing this change on people, but I also don't see a way to allow seamless migration while preserving the name new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make RecvAncillaryBuffer and SendAncillaryBuffer use MaybeUninits
1 participant
@SUPERCILEX