Repository navigation
fix(bindgen): align zero-length stream semantics with component model - #2362
Merged
vados-cosmonic merged 1 commit intoOct 31, 2026
Conversation
Collaborator
|
🎉 The code in this PR was made available in the following release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zero-length stream reads and writes currently skip pointer alignment checks and allow same-instance non-numeric transfers that copy no elements. Align these operations with WebAssembly/component-model#755.
Validate guest buffer alignment and the full requested range, including empty buffers and operations whose peer has dropped. Allow an empty buffer at the end of memory and preserve the ignored pointer for unit streams. Check the same-instance non-numeric restriction whenever both ends provide buffers, regardless of length.
Import the PR's zero-length and same-component WAST fixtures at commit
3e016227fbe8992dd1d54ca5efdfca543ad53b01, update the existing resource-stream regression, and add boundary and dropped-peer tests. Document the semantics in the Preview 3 stream guide.Validation:
js-component-bindgenRust library tests passed.git diff --checkpassed.