Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the "Full Media Stack" and "Pi-hole with LXC" guides. #10

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Alino001
Copy link

@Alino001 Alino001 commented Sep 3, 2023

Here`s what i have changed:

  • Simply added the Full Media Stack guide and Pi-hole with LXC guide

@Alino001 Alino001 changed the title Adding the "Full Media Stack" and "Pi-hole with LXC" Adding the "Full Media Stack" and "Pi-hole with LXC" guides. Sep 3, 2023
@bytebone bytebone added the enhancement New feature or request label Sep 3, 2023
@bytebone
Copy link
Owner

bytebone commented Sep 3, 2023

Hey Alino, thank you for your contribution! I have a couple thoughts.

Regarding the FMS:

  • There's still a bunch of typos throughout the document.
  • Since this guide directly sets up a way to pirate copyrighted content, there should be a clear disclaimer at the start about the possible legal repercussions.
  • The guide currently expects all apps to be hosted on a local machine, without a domain name. This would also mean that no access from outside the network is possible. Please either adjust the guide for use with a domain name (e.g. add the containers into docker networks and don't expose ports) or, if you have a good reason to keep this application local, add a disclaimer at the start explaining this difference.

PiHole:

  • Since LXC is an entirely different virtualization solution from Docker, I'd love to get a bit more explanation about what it is and how it works in the introduction. Parts like entering the container shell may be confusing for newcomers if they don't understand what they're doing.
  • This guide too works off of a locally hosted Pi-Hole instance instead of a remote one on a VPS. I'm not even sure how you would expose this to the public. Is this something you can add?

General:

  • The folders should be named in lowercase and with dashes for spaces (full-media-stack and pihole)
  • The main text documents should be called readme.md (This also fixes the guides being a single document in a folder of the sidebar)

I hope these points make sense to you. Let me know if you have any questions of feedback!

@Alino001
Copy link
Author

Alino001 commented Sep 3, 2023

Hello Rainer, thanks for the feedback!

I understand the issues, that you pointed out. I`ll try to fix those as much as i can. Thanks for the feedback!

minor changes to the wording and spelling
@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for how2host ready!

Name Link
🔨 Latest commit 8a877f2
🔍 Latest deploy log https://app.netlify.com/sites/how2host/deploys/64f5ccdc651aae0008ef0738
😎 Deploy Preview https://deploy-preview-10--how2host.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

minor changes to spelling and wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants