Prometheus on Kubernetes Example #15
Conversation
bill3tt
force-pushed
the
prometheus-kubernetes-example
branch
from
7a6aea7 to
07a2717
Compare
| namespace = "default" | ||
| alertManagerPort = 9093 | ||
| // This constant is not seemingly available in any of the k8s libraries | ||
| imagePullPolicyIfNotPresent = "IfNotPresent" |
There was a problem hiding this comment.
v1.PullIfNotPresent from v1 "k8s.io/api/core/v1"
| ) | ||
|
|
||
| var ( | ||
| int32One = int32(1) |
There was a problem hiding this comment.
kill this and let's use inlined swag.Int32 (:
| }, | ||
| Scheme: "https", | ||
| HTTPClientConfig: config.HTTPClientConfig{ | ||
| TLSConfig: config.TLSConfig{ |
There was a problem hiding this comment.
I think this is default, plus it repeats everywhere. Can we have helper here? (:
| }, | ||
| } | ||
|
|
||
| // TODO: Is there a cleaner way of doing this? |
There was a problem hiding this comment.
Nope, but it's actually neat (: Looks legit.
There was a problem hiding this comment.
We could have helper for that that saves 2 lines, but that's it (:
There was a problem hiding this comment.
we should add this to mimic:
func GenerateInPlace(r io.Reader) []byte {
b, err := ioutil.ReadAll(r)
if err != nil {
mimic.PanicErr(err)
}
return b
}
| }, | ||
| } | ||
|
|
||
| generator.Add("server-configmap.yaml", encoding.YAML(serverConfigMap)) |
There was a problem hiding this comment.
Wonder - we should do it at the end or one by one?
There was a problem hiding this comment.
Hmmm - trying them both out I like doing it all at the end better. That way we are grouping concerns together rather than having them spread out. Easier to reason about.
| } | ||
|
|
||
| func generateKubeStateMetrics(generator *mimic.Generator) { | ||
| // Kube-state-metrics |
|
|
||
| func generateNodeExporter(generator *mimic.Generator) { | ||
|
|
||
| // Node-exporter |
| { | ||
| Name: "metrics", | ||
| Port: 9100, | ||
| Protocol: "TCP", |
| @@ -2,17 +2,19 @@ module github.com/bwplotka/mimic | |||
|
|
|||
| go 1.12 | |||
|
|
|||
| replace github.com/prometheus/alertmanager => github.com/bwplotka/alertmanager v0.1.0-mimic-am-config | |||
| github.com/beorn7/perks v0.0.0-20180321164747-3a771d992973/go.mod h1:Dwedo/Wpr24TaqPxmxbtue+5NUziq4I4S80YR8gNf3Q= | ||
| github.com/beorn7/perks v1.0.0 h1:HWo1m869IqiPhD389kmkxeTalrjNbbJTC8LXupb+sl0= | ||
| github.com/beorn7/perks v1.0.0/go.mod h1:KWe93zE9D1o94FZ5RNwFwVgaQK1VOXiVxmqh+CedLV8= | ||
| github.com/bgentry/speakeasy v0.1.0/go.mod h1:+zsyZBPWlz7T6j88CTgSN5bM796AkVf0kBD4zp0CCIs= | ||
| github.com/bwplotka/alertmanager v0.1.0-mimic-am-config h1:ayiZ+4jriq3cFuI4QbecQUdbmCZXiuQE8jm+ZuMxSTI= |
There was a problem hiding this comment.
I think it's must have at some point to maintain separate go.mod for all examples as well as abstractions. Otherwise using mimic.Generator would pull all those dependencies..... even though the user might want Kubernetes only for example.
There was a problem hiding this comment.
bill3tt
force-pushed
the
prometheus-kubernetes-example
branch
from
a51df2c to
54b008a
Compare
|
Great idea, thanks! But we need somebody who would finish this up. Closing for now (: I talked with you offline and I know you are busy with other topics, so closing. |
This PR implements an example which defines and generates all of the configuration needed to run a fully-featured Prometheus instance on Kubernetes.