Skip to content

fix: let single-key shortcuts fire unless focus is in a text field - #842

Merged
srabraham merged 1 commit into
masterfrom
2026-09-28-modall-2
Sep 29, 2026
Merged

srabraham merged 1 commit into
masterfrom
2026-09-28-modall-2

Conversation

@srabraham

Copy link
Copy Markdown
Member

No description provided.

@srabraham
srabraham enabled auto-merge (rebase) September 29, 2026 01:29
@codecov-commenter

codecov-commenter commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.66%. Comparing base (148745b) to head (e75d031).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   83.62%   83.66%   +0.03%     
==========================================
  Files          85       85              
  Lines       11004    11000       -4     
  Branches     1169     1167       -2     
==========================================
+ Hits         9202     9203       +1     
+ Misses       1329     1326       -3     
+ Partials      473      471       -2     
Flag Coverage Δ
go 89.74% <ø> (-0.02%) ⬇️
typescript 77.17% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@srabraham
srabraham merged commit e3f51dd into master Sep 29, 2026
12 checks passed
@srabraham
srabraham deleted the 2026-09-28-modall-2 branch September 29, 2026 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants