Optimize memory usage and fix concurrency issues in middlewares#11
Open
bernardoforcillo wants to merge 4 commits into
Open
Optimize memory usage and fix concurrency issues in middlewares#11bernardoforcillo wants to merge 4 commits into
bernardoforcillo wants to merge 4 commits into
Conversation
- `Context.Reset`: Use `clear()` to reuse `Keys` map instead of reallocation, reducing garbage collection pressure.
- `Context.Clone`: Implement deep copy for thread-safe context usage in goroutines.
- `Timeout` Middleware:
- Fix data race by implementing `bufferedWriter` and cloning the context.
- Use `sync.Pool` for buffers to minimize allocation.
- Add panic recovery and safe error handling (discard buffer on error).
- `RateLimiter` Middleware:
- Switch to `sync.RWMutex` to allow concurrent checks.
- Use `atomic.Int64` for `lastSeen` timestamp (fixes 32-bit alignment and reduces lock contention).
- Optimize cleanup loop to use snapshots and avoid holding global lock.
- Tests: Added comprehensive tests for race conditions, timeouts, panics, and concurrency.
Co-authored-by: bernardoforcillo <28314446+bernardoforcillo@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- `amaro.go`: Configured default `ReadTimeout`, `WriteTimeout`, `IdleTimeout`, and `ReadHeaderTimeout` on `http.Server` to prevent resource exhaustion attacks. - `routers/trie.go`: Added `sync.RWMutex` to `TrieRouter` to ensure thread-safe concurrent route registration and lookup. - `routers/concurrency_test.go`: Added tests to verify concurrent route additions and lookups do not race. Co-authored-by: bernardoforcillo <28314446+bernardoforcillo@users.noreply.github.com>
- `amaro.go`:
- Introduced `ServerConfig` struct to hold HTTP server configuration.
- Updated `App` to store `ServerConfig`.
- Implemented `WithServerConfig` option for bulk configuration.
- Implemented granular options: `WithReadTimeout`, `WithWriteTimeout`, `WithIdleTimeout`, `WithReadHeaderTimeout`, `WithMaxHeaderBytes`.
- Updated `New` to initialize with `DefaultServerConfig`.
- Updated `startServer` to use the configured values.
- `config_test.go`: Added tests to verify configuration initialization.
Co-authored-by: bernardoforcillo <28314446+bernardoforcillo@users.noreply.github.com>
- `amaro.go`:
- Added `EnableH2C` to `ServerConfig` and `WithH2C` option.
- Updated `startServer` to wrap the handler with `h2c.NewHandler` if `EnableH2C` is true.
- Updated `go.mod` to include `golang.org/x/net/http2`.
- `h2c_test.go`: Added test to verify H2C option can be set.
Co-authored-by: bernardoforcillo <28314446+bernardoforcillo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses memory usage and concurrency issues across the framework.
Key changes:
Context.Resetnow reuses theKeysmap, significantly reducing allocations for high-throughput applications.Timeoutmiddleware where the handler could write to the response after a timeout. IntroducedBufferedResponseWriterandContext.Clone()to isolate the timed-out handler.RateLimiterto usesync.RWMutexandatomicoperations, preventing the cleanup loop from blocking all requests (potential deadlock/starvation).Timeoutmiddleware's background goroutine to prevent server crashes.Verified with
go test -raceand benchmarks showing 0 allocs/op forContext.Reset.PR created automatically by Jules for task 11866689832695415924 started by @bernardoforcillo