Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Buildbarn components 2025-02-14 #159

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Upgrade Buildbarn components 2025-02-14 #159

merged 1 commit into from
Feb 20, 2025

Conversation

stagnation
Copy link
Collaborator

No description provided.

@stagnation stagnation force-pushed the feature/upgrade-buildbarn-components-2025-02-14 branch 8 times, most recently from a31d2a5 to 8fa00d4 Compare February 19, 2025 13:26
@stagnation
Copy link
Collaborator Author 

Run bazel mod graph
 no actions running
 no actions running
 no actions running
 no actions running
 no actions running
 no actions running
 no actions running
ERROR: @@bazel_tools//tools/cpp:cc_configure.bzl does not export a module extension called cc_configure_extension, yet its use is requested at https://bcr.bazel.build/modules/re2/2024-07-02/MODULE.bazel:22:29
ERROR: Results may be incomplete as 1 extension failed.

This is an open upstream error: google/re2#525
Do we suppress that and wait or should I try to patch it?

@stagnation stagnation force-pushed the feature/upgrade-buildbarn-components-2025-02-14 branch from 8fa00d4 to 419f8ab Compare February 19, 2025 14:02
@stagnation stagnation force-pushed the feature/upgrade-buildbarn-components-2025-02-14 branch from 419f8ab to cc7f36b Compare February 19, 2025 14:22
@stagnation stagnation requested a review from moroten February 20, 2025 10:18
moroten
moroten approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@moroten moroten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annoying that bazel mod graph had to be disabled.

@moroten moroten merged commit 3405ec0 into buildbarn:master Feb 20, 2025
1 check passed
@stagnation stagnation deleted the feature/upgrade-buildbarn-components-2025-02-14 branch February 21, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moroten moroten moroten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stagnation @moroten