Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): echo service initialization #8791

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

adrianbenavides
Copy link
Member

@adrianbenavides adrianbenavides commented Feb 5, 2025

After the recent command optimization changes, we stopped creating a separated ockam context when creating a foreground node with configuration.

We've been avoiding that on purpose because we had a known bug that was causing the echo service to stop working correctly if the ockam context was shared.

Turns out that we were recreating the echo service after being set as a consumer for the secure channel listener:

  • start_echoer_service deletes the echoer service and recreates it, so this must be called first; otherwise, we lose the flow controls
  • initialize_default_services/create_secure_channel_listener adds the echoer as a consumer

@adrianbenavides adrianbenavides force-pushed the adrian/echo-service-init branch from acfa294 to f3196c1 Compare February 5, 2025 18:45
@adrianbenavides adrianbenavides marked this pull request as ready for review February 7, 2025 07:49
@adrianbenavides adrianbenavides requested a review from a team as a code owner February 7, 2025 07:49
@adrianbenavides adrianbenavides force-pushed the adrian/echo-service-init branch from e0c1ae8 to 8778970 Compare February 7, 2025 08:33
@adrianbenavides adrianbenavides added this pull request to the merge queue Feb 10, 2025
Merged via the queue into develop with commit a5c7586 Feb 10, 2025
32 checks passed
@adrianbenavides adrianbenavides deleted the adrian/echo-service-init branch February 10, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants