Week 11 #1
Open
Week 11 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsto
requested changes
Mar 17, 2025
| case BedrockModel.deepseek_r1_v1.id: | ||
| self = BedrockModel.deepseek_r1_v1 | ||
| default: | ||
| return nil |
There was a problem hiding this comment.
nil ? the user will not be able to use it's own model then. It should return a generic instance, with rawvalue that the user can use even if we did not add support for it
| public init() {} | ||
|
|
||
| public func invokeModel(input: InvokeModelInput) async throws -> InvokeModelOutput { | ||
| guard let modelId = input.modelId else { |
There was a problem hiding this comment.
not sur ethese are required in a mock - unless you have tests to check these
There was a problem hiding this comment.
I added these because the modelId and body are optionals in InvokeModelInput in the BedrockRuntime SDK, so to make sure SwiftBedrock actually created a valid InvokeModelInput I added these checks. The real client would throw an error as well if no modelId or prompt was given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.