Fix RootDetection background ANR #2202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-14377/fix-background-anr
branch
from
2963269 to
b2c6334
Compare
Android notifier sizes
Generated by 🚫 Danger |
lemnik
force-pushed
the
PLAT-14377/fix-background-anr
branch
from
b2c6334 to
31b6fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix background ANRs that occur on startup when waiting for the
RootDetectionsub-process to complete.Design
Added a timed
Process.waitForto theRootDetectionto limit the amount of time the sub-process can take before we continue with startup.Also generally moved more of the startup process waits to later to allow more to complete in parallel.
Testing
Manually tested blocking the sub-process, and relied on existing tests for the remaining changes.