Skip to content

Conversation

@smertnik3sh
Copy link

@smertnik3sh smertnik3sh commented Feb 6, 2025

When you use remote execution, your "host" and "execution" platforms may differ. For example you can run the build on a remote Linux cluster from your Mac. In this case, choosing binary files like here is incorrect (Linux agent trying to run Mac binary).

In this patch, repositories with binaries for each platform are generated. Repositories are linked to the toolchains. As a result, during the build process, basel gets the correct versions of the binaries.

I think that the described problem has been fixed in this pr. But I can't check it because it's based on too old rules version).
If you plan to integrate changes from that pr to actual code base - just close my pr.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2025

CLA assistant check
All committers have signed the CLA.

@srikrsna-buf
Copy link
Member

I tried to run this using Bazel 7 and it was unable to locate the toolchains.

@smertnik3sh
Copy link
Author

Strange... In our repository everything is ok. We use bazel 7.5.0. Can you send me full error text pls? What os and cpu arch you use?

@smertnik3sh
Copy link
Author

smertnik3sh commented Feb 12, 2025

I found problem that looked like "execvp( ... /external/rules_buf++buf+rules_buf_toolchains/buf, ...)": No such file or directory" when running bazel in examples. Was you spoke about that one?
After last commit results of "bazel test //..." (bazel version 7.5.0) inside examples before and after patch look like the same.

@srikrsna-buf
Copy link
Member

Thank you for looking into it. I still see that issue if I run USE_BAZEL_VERSION=7.2.0 bazel test //... inside the workspace example

@srikrsna-buf srikrsna-buf mentioned this pull request May 7, 2025
@srikrsna-buf
Copy link
Member

@smertnik3sh Can you sign the CLA? I'll take a look at the error and merge this

@smertnik3sh smertnik3sh force-pushed the fix-remote-execution branch from bcec3ce to ebe8d14 Compare May 30, 2025 16:11
@smertnik3sh
Copy link
Author

smertnik3sh commented May 30, 2025

I already signed, but last commit from this pr had wrong metadata (wrong email). I paid no attention, sorry.

@chrispine chrispine requested a review from srikrsna-buf June 24, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants