-
Notifications
You must be signed in to change notification settings - Fork 34
Fix remote execution #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I tried to run this using Bazel 7 and it was unable to locate the toolchains. |
|
Strange... In our repository everything is ok. We use bazel 7.5.0. Can you send me full error text pls? What os and cpu arch you use? |
|
I found problem that looked like "execvp( ... /external/rules_buf++buf+rules_buf_toolchains/buf, ...)": No such file or directory" when running bazel in examples. Was you spoke about that one? |
|
Thank you for looking into it. I still see that issue if I run |
|
@smertnik3sh Can you sign the CLA? I'll take a look at the error and merge this |
Signed-off-by: Sergei Shirshanov <[email protected]>
bcec3ce to
ebe8d14
Compare
|
I already signed, but last commit from this pr had wrong metadata (wrong email). I paid no attention, sorry. |
When you use remote execution, your "host" and "execution" platforms may differ. For example you can run the build on a remote Linux cluster from your Mac. In this case, choosing binary files like here is incorrect (Linux agent trying to run Mac binary).
In this patch, repositories with binaries for each platform are generated. Repositories are linked to the toolchains. As a result, during the build process, basel gets the correct versions of the binaries.
I think that the described problem has been fixed in this pr. But I can't check it because it's based on too old rules version).
If you plan to integrate changes from that pr to actual code base - just close my pr.