Use os.Copy over os.Rename to avoid os restrictions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some environments the temp directory used for downloads may not be able to use os.Rename. In docker with caching enabled this fails, as the directory is a volume mount, with the error: "invalid cross-device link". Another small fix is to hash the file using the io.Copy to avoid reading the binary into memory.
emcfarlane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves support for bufisk running in CI environments. Adds a fallback for
os.Renameto callos.Copy.os.Renamecan fail when the destination and source file are not in the same volume. This was noticed in a GitHub action workflow where downloads were mounted in a cache volume, the error"invalid cross-device link"was returned but we don't check for errors as they may be os specific.