refactor: use system admin word correctly #782
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on renaming the error
ErrAdminAccountNotFound
toErrSystemAdminAccountNotFound
and updating the associated SQL query in thepkg/account
package. The changes ensure that the correct error and SQL query are used when retrieving a system admin account.Here are the key changes:
pkg/account/storage/v2/admin_account.go
: Renamed the errorErrAdminAccountNotFound
toErrSystemAdminAccountNotFound
and updated the SQL query fromselectAdminAccountV2SQL
toselectSystemAdminAccountV2SQL
. This change affects theGetSystemAdminAccountV2
method where the new error is returned when the system admin account is not found. [1] [2]pkg/account/api/admin_account.go
: Updated thegetSystemAdminAccountV2
method in theAccountService
to check for the new errorErrSystemAdminAccountNotFound
instead of the old error.pkg/account/api/admin_account_test.go
andpkg/account/storage/v2/admin_account_test.go
: Updated the test cases to expect the new errorErrSystemAdminAccountNotFound
instead of the old error. [1] [2]