chore: add schedule update field to feature proto message #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
cre8ivejp
commented
Feb 3, 2025
| @@ -53,6 +53,7 @@ message Feature { | |||
| bool archived = 20; | |||
| repeated Prerequisite prerequisites = 21; | |||
| string sampling_seed = 22; | |||
| repeated ScheduleUpdate schedule_update = 23; | |||
There was a problem hiding this comment.
Because the user might want to schedule multiple times, I'm using an array, so when implementing it on the frontend, we won't need to make changes on the backend.
For the first phase, I will allow the user to schedule only once at a time.
cre8ivejp
added a commit
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
cre8ivejp
added a commit
that referenced
this pull request
Feb 4, 2025
…1503) Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #893
The batch svc will check all the flags with scheduled updates.
If the
update_atis older than the current time, it will replace the current feature object with the object in theScheduleUpdatein the DB.