Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag deleter #1469

Merged
merged 2 commits into from
Jan 22, 2025
Merged

feat: add tag deleter #1469

merged 2 commits into from
Jan 22, 2025

Conversation

cre8ivejp
Copy link
Member

@cre8ivejp cre8ivejp commented Jan 21, 2025

Fix #1358

To the tag be deleted, the user must remove the tag from the feature flag on the detail settings tab.
By default, the job will run once every day in production and every minute in the dev container.

Logs

{"severity":"INFO","eventTime":1737446220.7638857,"logger":"bucketeer-batch.server.tag-deleter","caller":"deleter/tag_deleter.go:66","message":"Starting to delete unused tags","serviceContext":{"service":"bucketeer-batch.server","version":"-"}}
{"severity":"DEBUG","eventTime":1737446220.7873087,"logger":"bucketeer-batch.server.tag-deleter","caller":"deleter/tag_deleter.go:137","message":"Deleted tag successfully","serviceContext":{"service":"bucketeer-batch.server","version":"-"},"tagId":"3a9d2dbc-b035-47ea-95dc-b2bfb0edd738","tagName":"web","environmentId":"demo"}
{"severity":"INFO","eventTime":1737446220.7873363,"logger":"bucketeer-batch.server.tag-deleter","caller":"deleter/tag_deleter.go:100","message":"Finished deleting unused tags","serviceContext":{"service":"bucketeer-batch.server","version":"-"},"elapsedTime":0.023418084,"deletedSize":1}

Things done

  • Added a batch to delete unused tags
  • Added unit tests

Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
@cre8ivejp cre8ivejp marked this pull request as ready for review January 21, 2025 13:44
@cre8ivejp cre8ivejp requested review from Ubisoft-potato and hvn2k1 and removed request for kentakozuka January 21, 2025 13:44
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Copy link
Contributor

@hvn2k1 hvn2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cre8ivejp cre8ivejp merged commit 6558bd0 into main Jan 22, 2025
19 checks passed
@cre8ivejp cre8ivejp deleted the chore-tag-deleter branch January 22, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: delete unused tags automatically in the feature flag dashboard
2 participants