feat: implement get create list experiments no command #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvn2k1
force-pushed
the
feat/get-experiment-rest
branch
from
8b34aa4 to
c916823
Compare
kakcy
reviewed
Jan 22, 2025
cre8ivejp
reviewed
Jan 22, 2025
proto/experiment/service.proto
Outdated
Comment on lines
186
to
192
| string feature_id = 4; | ||
| int64 start_at = 5; | ||
| int64 stop_at = 6; | ||
| repeated string goal_ids = 7; | ||
| string name = 8; | ||
| string description = 9; | ||
| string base_variation_id = 10; |
There was a problem hiding this comment.
Besides the description, all fields are required.
There was a problem hiding this comment.
I have added required field behavior, and also add the count of waiting, running and stopped experiment
hvn2k1
force-pushed
the
feat/get-experiment-rest
branch
from
f03a9d5 to
9af6ab8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1417