Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag service #1443

Merged
merged 9 commits into from
Jan 14, 2025
Merged

feat: add tag service #1443

merged 9 commits into from
Jan 14, 2025

Conversation

cre8ivejp
Copy link
Member

@cre8ivejp cre8ivejp commented Jan 9, 2025

Part of #1090

I'll delete the list tags API implementation from the feature service in another PR.

Things done

  • Added CreateTag API
  • Added ListTags API
  • Added DeleteTag API
  • Added e2e tests

@cre8ivejp cre8ivejp force-pushed the chore-tags-svc branch 14 times, most recently from 5d1e203 to 0280067 Compare January 11, 2025 07:42
@cre8ivejp cre8ivejp marked this pull request as ready for review January 14, 2025 01:58
@cre8ivejp cre8ivejp requested review from Ubisoft-potato and removed request for kentakozuka January 14, 2025 01:58
address:
socket_address:
address: localhost
port_value: 9104
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using 9104 for CodeRef API, after mergeing this PR I will change CodeRef API port to 9105.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Ubisoft-potato
Ubisoft-potato previously approved these changes Jan 14, 2025
Copy link
Collaborator

@Ubisoft-potato Ubisoft-potato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!! 👍

Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
@cre8ivejp cre8ivejp merged commit bf69850 into main Jan 14, 2025
18 checks passed
@cre8ivejp cre8ivejp deleted the chore-tags-svc branch January 14, 2025 06:44
steveninhle pushed a commit that referenced this pull request Jan 17, 2025
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants