feat: add tag domain and storage implementation #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cre8ivejp
force-pushed
the
chore-tags-table
branch
from
d307c1b to
507d25e
Compare
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
cre8ivejp
force-pushed
the
chore-tags-table
branch
from
507d25e to
b6ede71
Compare
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
cre8ivejp
requested review from
Ubisoft-potato
and removed request for
kentakozuka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1090
I will implement the Tag service to list tags.
Currently, we have a list tags API in the feature service, but I will move that API to the Tag service because the Tag won't be related only to features anymore.
The Tag table will have tags from other Entities, such as Experiments, Goals, Segments, etc.
Things done
entity_typecolumn to the tag table