feat: code reference API #1395
Merged
feat: code reference API #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubisoft-potato
force-pushed
the
feat-code-ref-table
branch
2 times, most recently
from
c73147d to
762205c
Compare
Ubisoft-potato
force-pushed
the
feat-code-ref-table
branch
7 times, most recently
from
53057e8 to
2929f7f
Compare
Ubisoft-potato
force-pushed
the
feat-code-ref-table
branch
2 times, most recently
from
6264d91 to
a4d5fe8
Compare
Ubisoft-potato
requested review from
cre8ivejp and
kentakozuka
as code owners
Ubisoft-potato
force-pushed
the
feat-code-ref-table
branch
8 times, most recently
from
9c810ff to
68f2265
Compare
cre8ivejp
reviewed
Jan 22, 2025
| EnvironmentId: *environmentID, | ||
| } | ||
| _, err = client.GetCodeReference(context.Background(), getReq) | ||
| assert.Error(t, err) // Should return error as code reference is deleted |
There was a problem hiding this comment.
We must check the response code in case the backend returns any other error than not found.
cre8ivejp
reviewed
Jan 22, 2025
pkg/coderef/api/code_reference.go
Outdated
Comment on lines
233
to
261
| id, err := uuid.NewUUID() | ||
| if err != nil { | ||
| s.logger.Error( | ||
| "Failed to generate uuid", | ||
| log.FieldsFromImcomingContext(ctx).AddFields( | ||
| zap.Error(err), | ||
| )..., | ||
| ) | ||
| dt, err := statusInternal.WithDetails(&errdetails.LocalizedMessage{ | ||
| Locale: localizer.GetLocale(), | ||
| Message: localizer.MustLocalize(locale.InternalServerError), | ||
| }) | ||
| if err != nil { | ||
| return nil, statusInternal.Err() | ||
| } | ||
| return nil, dt.Err() | ||
| } |
There was a problem hiding this comment.
Please move the UUID logic to the domain.NewCodeReference as we do for the other entities.
pkg/coderef/api/code_reference.go
Outdated
| ) | ||
| if err != nil { | ||
| s.logger.Error( | ||
| "Failed to update code reference", |
There was a problem hiding this comment.
Suggested change
| "Failed to update code reference", | |
| "Failed to update code reference domain object", |
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package v2 |
There was a problem hiding this comment.
Since this is new, we don't need the v2.
Suggested change
| package v2 | |
| package storage |
| return codeRefs, nextOffset, total, nil | ||
| } | ||
|
|
||
| func (s *codeReferenceStorage) DeleteCodeReference(ctx context.Context, id, environmentID string) error { |
There was a problem hiding this comment.
Since we are using UUID, we don't need the environment ID in the storage layer.
Suggested change
| func (s *codeReferenceStorage) DeleteCodeReference(ctx context.Context, id, environmentID string) error { | |
| func (s *codeReferenceStorage) DeleteCodeReference(ctx context.Context, id string) error { |
…statement for better clarity
…clarity in code_reference table
…d update related logic
Ubisoft-potato
force-pushed
the
feat-code-ref-table
branch
from
5b77abb to
bf6b77c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partf of #888
Add Code Reference API
This PR adds new gRPC service endpoints and related message types for managing code references in the Bucketeer system.
Changes
New Service Endpoints
Added new CodeReferenceService with the following methods:
GetCodeReferenceListCodeReferencesCreateCodeReferenceUpdateCodeReferenceDeleteCodeReferenceNew Event Types
Added new event types for code reference operations:
CODE_REFERENCE_CREATEDCODE_REFERENCE_UPDATEDCODE_REFERENCE_DELETEDNew Domain Events
Added corresponding domain event message types:
CodeReferenceCreatedEventCodeReferenceUpdatedEventCodeReferenceDeletedEvent