feat: add organization_id condition for list api key #1373
+1,721
−1,358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubisoft-potato
force-pushed
the
feat-list-api-key
branch
from
25e31fd to
8ad877d
Compare
Ubisoft-potato
requested review from
cre8ivejp and
kentakozuka
as code owners
cre8ivejp
reviewed
Dec 12, 2024
| @@ -256,6 +259,7 @@ message ListAPIKeysRequest { | |||
| google.protobuf.BoolValue disabled = 7; | |||
| string environment_id = 8 [deprecated = true]; | |||
| repeated string environment_ids = 9; | |||
| string organization_id = 10 [(google.api.field_behavior) = REQUIRED]; | |||
There was a problem hiding this comment.
We must support both consoles.
While making the organization_id required, the current console won't work because it sends the environment_id.
So, we would need to add the organization_id when making requests from the current console with the environment_id.
cre8ivejp
force-pushed
the
feat-list-api-key
branch
from
3b93269 to
0a213c9
Compare
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
cre8ivejp
force-pushed
the
feat-list-api-key
branch
from
bf57f7f to
1485a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.