Skip to content

Commit

Permalink
chore: add feature_flag_tags field to the proto files
Browse files Browse the repository at this point in the history
Signed-off-by: Alessandro Yuichi Okimoto <[email protected]>
  • Loading branch information
cre8ivejp committed Jan 22, 2025
1 parent d56ebab commit f67abbc
Show file tree
Hide file tree
Showing 18 changed files with 1,261 additions and 488 deletions.
26 changes: 26 additions & 0 deletions api-description/web-api.swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7033,6 +7033,10 @@ definitions:
$ref: '#/definitions/notificationRecipient'
name:
type: string
featureFlagTags:
type: array
items:
type: string
notificationCreateSubscriptionRequest:
type: object
properties:
Expand All @@ -7048,6 +7052,10 @@ definitions:
$ref: '#/definitions/SubscriptionSourceType'
recipient:
$ref: '#/definitions/notificationRecipient'
featureFlagTags:
type: array
items:
type: string
required:
- environmentId
- name
Expand Down Expand Up @@ -7236,8 +7244,19 @@ definitions:
type: string
environmentName:
type: string
featureFlagTags:
type: array
items:
type: string
notificationUpdateAdminSubscriptionResponse:
type: object
notificationUpdateSubscriptionFeatureFlagTagsCommand:
type: object
properties:
featureFlagTags:
type: array
items:
type: string
notificationUpdateSubscriptionRequest:
type: object
properties:
Expand All @@ -7264,6 +7283,13 @@ definitions:
type: boolean
description: if true, the subscription is disabled, otherwise enabled.
title: disabled
featureFlagTags:
type: array
items:
type: string
updateSubscriptionFeatureTagsCommand:
$ref: '#/definitions/notificationUpdateSubscriptionFeatureFlagTagsCommand'
description: Deprecated. Use feature_flag_tags instead.
required:
- id
- environmentId
Expand Down
4 changes: 2 additions & 2 deletions manifests/bucketeer/charts/web/values.yaml

Large diffs are not rendered by default.

Binary file modified proto/auditlog/proto_descriptor.pb
Binary file not shown.
200 changes: 138 additions & 62 deletions proto/notification/command.pb.go

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions proto/notification/command.proto
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ message CreateSubscriptionCommand {
repeated Subscription.SourceType source_types = 1;
Recipient recipient = 2;
string name = 3;
repeated string feature_flag_tags = 4;
}

message AddSourceTypesCommand {
Expand All @@ -58,6 +59,10 @@ message DeleteSourceTypesCommand {
repeated Subscription.SourceType source_types = 1;
}

message UpdateSubscriptionFeatureFlagTagsCommand {
repeated string feature_flag_tags = 1;
}

message EnableSubscriptionCommand {}

message DisableSubscriptionCommand {}
Expand Down
Binary file modified proto/notification/proto_descriptor.pb
Binary file not shown.
790 changes: 418 additions & 372 deletions proto/notification/service.pb.go

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions proto/notification/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ message CreateSubscriptionRequest {
repeated Subscription.SourceType source_types = 5
[(google.api.field_behavior) = REQUIRED];
Recipient recipient = 6 [(google.api.field_behavior) = REQUIRED];
repeated string feature_flag_tags = 7;
}

message CreateSubscriptionResponse {
Expand Down Expand Up @@ -231,6 +232,14 @@ message UpdateSubscriptionRequest {
title: "disabled"
description: "if true, the subscription is disabled, otherwise enabled."
}];
repeated string feature_flag_tags = 10;
UpdateSubscriptionFeatureFlagTagsCommand
update_subscription_feature_tags_command = 11 [
deprecated = true,
(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field) = {
description: "Deprecated. Use feature_flag_tags instead."
}
];
}

message UpdateSubscriptionResponse {
Expand Down
97 changes: 54 additions & 43 deletions proto/notification/subscription.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions proto/notification/subscription.proto
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ message Subscription {
string name = 7;
string environment_id = 8;
string environment_name = 9;
repeated string feature_flag_tags = 10;
}
55 changes: 55 additions & 0 deletions proto/proto.lock
Original file line number Diff line number Diff line change
Expand Up @@ -29349,6 +29349,12 @@
"id": 3,
"name": "name",
"type": "string"
},
{
"id": 4,
"name": "feature_flag_tags",
"type": "string",
"is_repeated": true
}
]
},
Expand All @@ -29374,6 +29380,17 @@
}
]
},
{
"name": "UpdateSubscriptionFeatureFlagTagsCommand",
"fields": [
{
"id": 1,
"name": "feature_flag_tags",
"type": "string",
"is_repeated": true
}
]
},
{
"name": "EnableSubscriptionCommand"
},
Expand Down Expand Up @@ -30255,6 +30272,12 @@
"value": "REQUIRED"
}
]
},
{
"id": 7,
"name": "feature_flag_tags",
"type": "string",
"is_repeated": true
}
],
"reserved_ids": [
Expand Down Expand Up @@ -30470,6 +30493,32 @@
]
}
]
},
{
"id": 10,
"name": "feature_flag_tags",
"type": "string",
"is_repeated": true
},
{
"id": 11,
"name": "update_subscription_feature_tags_command",
"type": "UpdateSubscriptionFeatureFlagTagsCommand",
"options": [
{
"name": "deprecated",
"value": "true"
},
{
"name": "(grpc.gateway.protoc_gen_openapiv2.options.openapiv2_field)",
"aggregated": [
{
"name": "description",
"value": "Deprecated. Use feature_flag_tags instead."
}
]
}
]
}
],
"reserved_ids": [
Expand Down Expand Up @@ -31246,6 +31295,12 @@
"id": 9,
"name": "environment_name",
"type": "string"
},
{
"id": 10,
"name": "feature_flag_tags",
"type": "string",
"is_repeated": true
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion ui/web-v2/src/assets/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -633,4 +633,4 @@
"urlCode": "URL code",
"warning": "Warning",
"yes": "Yes"
}
}
43 changes: 43 additions & 0 deletions ui/web-v2/src/proto/notification/command_pb.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,11 @@ export class CreateSubscriptionCommand extends jspb.Message {
getName(): string;
setName(value: string): void;

clearFeatureFlagTagsList(): void;
getFeatureFlagTagsList(): Array<string>;
setFeatureFlagTagsList(value: Array<string>): void;
addFeatureFlagTags(value: string, index?: number): string;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): CreateSubscriptionCommand.AsObject;
static toObject(
Expand Down Expand Up @@ -315,6 +320,7 @@ export namespace CreateSubscriptionCommand {
>;
recipient?: proto_notification_recipient_pb.Recipient.AsObject;
name: string;
featureFlagTagsList: Array<string>;
};
}

Expand Down Expand Up @@ -406,6 +412,43 @@ export namespace DeleteSourceTypesCommand {
};
}

export class UpdateSubscriptionFeatureFlagTagsCommand extends jspb.Message {
clearFeatureFlagTagsList(): void;
getFeatureFlagTagsList(): Array<string>;
setFeatureFlagTagsList(value: Array<string>): void;
addFeatureFlagTags(value: string, index?: number): string;

serializeBinary(): Uint8Array;
toObject(
includeInstance?: boolean
): UpdateSubscriptionFeatureFlagTagsCommand.AsObject;
static toObject(
includeInstance: boolean,
msg: UpdateSubscriptionFeatureFlagTagsCommand
): UpdateSubscriptionFeatureFlagTagsCommand.AsObject;
static extensions: { [key: number]: jspb.ExtensionFieldInfo<jspb.Message> };
static extensionsBinary: {
[key: number]: jspb.ExtensionFieldBinaryInfo<jspb.Message>;
};
static serializeBinaryToWriter(
message: UpdateSubscriptionFeatureFlagTagsCommand,
writer: jspb.BinaryWriter
): void;
static deserializeBinary(
bytes: Uint8Array
): UpdateSubscriptionFeatureFlagTagsCommand;
static deserializeBinaryFromReader(
message: UpdateSubscriptionFeatureFlagTagsCommand,
reader: jspb.BinaryReader
): UpdateSubscriptionFeatureFlagTagsCommand;
}

export namespace UpdateSubscriptionFeatureFlagTagsCommand {
export type AsObject = {
featureFlagTagsList: Array<string>;
};
}

export class EnableSubscriptionCommand extends jspb.Message {
serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): EnableSubscriptionCommand.AsObject;
Expand Down
Loading

0 comments on commit f67abbc

Please sign in to comment.