Keep ROM folders out of individual source settings

[btsouth]

ROM Folders appeared below every source's settings. Keep the section on the Sources overview, alongside manually added games and extra GOG folders.

Fixes #40.

Validation:

• Release build and all 124 CTest cases passed.
• The isolated QML check reproduces the old bug and passes 52 visibility transitions with the fix, covering source pages in desktop and Couch Mode.
• Live desktop and Couch Mode checks passed across all 12 source pages, including keyboard focus and returning to the Sources overview.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 9f1e138a-f5cb-425d-88b3-43adf733b03a

📥 Commits

Reviewing files that changed from the base of the PR and between a109965 and cea429c.

📒 Files selected for processing (1)

• qml/components/SettingsPanel.qml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The ROM folders section now hides when settingsOverlay.sourceDetail contains a source detail identifier. It remains visible when no source detail view is open and demo mode is inactive.

Changes

Settings panel visibility

Layer / File(s)	Summary
ROM folders visibility qml/components/SettingsPanel.qml	The visible condition now requires settingsOverlay.sourceDetail === "" in addition to !DemoMode.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cea42

ROM Folder settings now remain on the Sources overview and no longer appear within individual source settings. The focused UI change has passed the reported build and visibility checks and is ready to merge.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The change hides the ROM Folders section when a source detail view is open. This addresses issue #40, which reports that ROM Folders appeared under every library details section.
Out of Scope Changes check	✅ Passed	The one-line QML change is directly related to the linked issue and stated objectives. No unrelated changes are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preventing ROM folders from appearing in individual source settings.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/issue-40-rom-settings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}