Skip to content

feat: switch to pygame-ce for vsync support + make setup.sh executeable - #5

Open
p1geondove wants to merge 1 commit into
bterwijn:mainfrom
p1geondove:feat_add_vsync
Open

feat: switch to pygame-ce for vsync support + make setup.sh executeable#5
p1geondove wants to merge 1 commit into
bterwijn:mainfrom
p1geondove:feat_add_vsync

Conversation

@p1geondove

Copy link
Copy Markdown
  • changed requirements.txt from pygame to pygame-ce
  • added vsync=1 flag to pygame.display.set_mode
  • removed Game.frames_per_second
  • made setup.sh executable

what are we thinking about using astral / uv? i would change to that, but thats a semi-major thing and not everyone has uv installed (even tho everyone should imo :D)

@bterwijn

Copy link
Copy Markdown
Owner

It says here vsync is experimental:

https://www.pygame.org/docs/ref/display.html#pygame.display.set_mode

is it stable on all systems?

Why are you pushing for pygame-ce, what's the benefit for this project? is it stable on all systems?

Why remove the frames_per_second variable to control game speed, did you even test?

I'm really not interested in project management details or using uv, as it should be as easy as possible for people to join this collaborative project. Maybe add some fun game elements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants