Optimization with windowed shamir, correction of bugs #1
Open
rdubois-crypto wants to merge 25 commits intobtchip:mainfrom
Open
Optimization with windowed shamir, correction of bugs #1rdubois-crypto wants to merge 25 commits intobtchip:mainfrom
rdubois-crypto wants to merge 25 commits intobtchip:mainfrom
Conversation
added 25 commits
February 22, 2023 15:33
- multiplication using windowing and Shamir's trick, imported from https://github.com/rdubois-crypto/MyCairoPlayground/blob/main/Cairo/cairo_secp256r1/src/ec_mulmuladd_secp256r1.cairo - correcting incorrect Neutral Point representation (use of Affine while Projective is required in some places) - removing incorrect point normalization at end of file (looks like an old jacobian implementation) Note : - Shamir's trick:https://crypto.stackexchange.com/questions/99975/strauss-shamir-trick-on-ec-multiplication-by-scalar, - Windowing method : https://en.wikipedia.org/wiki/Exponentiation_by_squaring, section 'sliding window' The implementation uses a 2 bits window with trick, leading to a 16 points elliptic point precomputation */
- Inverting y in dbl loop to spare sub - Using continue to jump the 0 case of mul loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double base multiplication using windowing and Shamir's trick, imported from https://github.com/rdubois-crypto/MyCairoPlayground/blob/main/Cairo/cairo_secp256r1/src/ec_mulmuladd_secp256r1.cairo
Correction of Neutral point representation (could lead to error)
Suppression of incorrect point normalization at end of file (remnant of a jacobian representation ?)