chore(ci): fix lint, brakeman, and test command#34
Merged
Conversation
- Rubocop: auto-corrected Layout/HashAlignment in
ConnectionScoreCalculator and its spec.
- Brakeman: rewrote Person.with_upcoming_events to use
integer-encoded month*100+day instead of an interpolated
tuple IN clause. Same semantics, no string interpolation,
resolves the weak SQL-injection warning.
- CI test job: project uses RSpec; switched the runner from
�[1mUnrecognized command "test" (�[1;4mRails::Command::UnrecognizedCommandError�[m�[1m)�[m (Minitest) to
/home/brian/.rbenv/versions/3.4.8/bin/ruby -I/home/brian/.rbenv/versions/3.4.8/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.6/lib:/home/brian/.rbenv/versions/3.4.8/lib/ruby/gems/3.4.0/gems/rspec-support-3.13.7/lib /home/brian/.rbenv/versions/3.4.8/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.6/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
............................*........................................................................................................
Pending: (Failures listed here are expected and do not affect your suite's status)
1) User add some examples to (or delete) /home/brian/projects/saber/spec/models/user_spec.rb
# Not yet implemented
# ./spec/models/user_spec.rb:4
Finished in 0.62195 seconds (files took 0.32583 seconds to load)
133 examples, 0 failures, 1 pending.
These checks have been failing since M5; M5 backend likely
merged via admin bypass. Landing this first so M6 frontend
PR #33 can rebase onto green main.
- Patches GHSA-c4rq-3m3g-8wgx (High, CSS selector tokenizer regex backtracking) and GHSA-v2fc-qm4h-8hqv (Medium, XSLT memory leak). - Surfaced by `bin/bundler-audit` in the scan_ruby CI job, which was already failing alongside the other three issues in this PR. - Transitive update only — no `Gemfile` change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectionScoreCalculator and its spec.
integer-encoded month*100+day instead of an interpolated
tuple IN clause. Same semantics, no string interpolation,
resolves the weak SQL-injection warning.
�[1mUnrecognized command "test" (�[1;4mRails::Command::UnrecognizedCommandError�[m�[1m)�[m (Minitest) to
/home/brian/.rbenv/versions/3.4.8/bin/ruby -I/home/brian/.rbenv/versions/3.4.8/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.6/lib:/home/brian/.rbenv/versions/3.4.8/lib/ruby/gems/3.4.0/gems/rspec-support-3.13.7/lib /home/brian/.rbenv/versions/3.4.8/lib/ruby/gems/3.4.0/gems/rspec-core-3.13.6/exe/rspec --pattern spec/**{,/*/**}/*_spec.rb
............................*........................................................................................................
Pending: (Failures listed here are expected and do not affect your suite's status)
Not yet implemented
./spec/models/user_spec.rb:4
Finished in 0.62195 seconds (files took 0.32583 seconds to load)
133 examples, 0 failures, 1 pending.
These checks have been failing since M5; M5 backend likely
merged via admin bypass. Landing this first so M6 frontend
PR #33 can rebase onto green main.