Merge pull request #360 from alexbarcelo/patch-3

Improper use of combinations_with_replacement
bsc-wdc · Nov 4, 2021 · c2ebf61 · c2ebf61
2 parents 69cc801 + 3c562f2
commit c2ebf61
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/dislib/math/base.py b/dislib/math/base.py
@@ -171,13 +171,11 @@ def svd(a, compute_uv=True, sort=True, copy=True, eps=1e-9):
     while not _check_convergence_svd(checks):
         checks = []
 
-        pairings = itertools.combinations_with_replacement(
+        pairings = itertools.combinations(
             range(x._n_blocks[1]), 2
         )
 
         for i, j in pairings:
-            if i >= j:
-                continue
             coli_x = x._get_col_block(i)
             colj_x = x._get_col_block(j)