Geometry class refactoring to increase type-safety#43
Open
YasharSL wants to merge 4 commits intobrunosimon:masterfrom
Open
Geometry class refactoring to increase type-safety#43YasharSL wants to merge 4 commits intobrunosimon:masterfrom
YasharSL wants to merge 4 commits intobrunosimon:masterfrom
Conversation
- Property `parameters` does not exist on `BufferGeometry` and returning a `BoxGeometry` in the constructor causes incorrect type exporting. - The previous code will throw an error in TypeScript
- Property `parameters` does not exist on `BufferGeometry` and returning a `BoxGeometry` in the constructor causes incorrect type exporting. - The previous code will throw an error in TypeScript
…olio-2019 into Refactor-Increase-type-safety
…ype-safety - Updated `AreaFenceGeometry` to extend `THREE.BufferGeometry` for better integration with Three.js. - This follows latest Threejs recommendations
YasharSL
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AreaFloorBorderGeometryAreaFenceGeometryparametersdoes not exist onBufferGeometryand returning aBoxGeometryin the constructor causes incorrect type exporting.