doc: Add missing import for Control.FullScreen.css #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this import. The svg button is not loaded and yo end up with a "blank button"
|
Any thought on this @BePo65 ? |
|
I'll take a look at it on the next weekend - quite busy at the moment :-) |
|
Basically we could give some hints on how the "Include Control.FullScreen.css in your page" from the "How?" section can be done in esm based frameworks. But the PR is for react only. So perhaps it would be better to add a 3rd point, which could look like: |
|
@danidee10 could you update your PR as suggested by @BePo65 ? |
|
bump @danidee10 or should we close this issue ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this import. The svg button is not loaded and yo end up with a "blank button"