restore native PGF quick commands #2490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part two of #2401 (to fully fix #2399): the quick commands by definition must not alter the bounding box. They do this by altering
relevantforpicturesize, so this depends on the other PR to actually have an effect. This changes how some of Silviu's test are rendered (for the better) although plenty of stuff is still broken.As far as I can tell, the initial implementation of PGF was extremely conservative about stuff being drawn outside of the SVG bounding box, hence the disabling of
relevantforpicturesizeand the redefinition of the quick commands. I don't think this is necessary anymore.