Fixed the unloading severe warning by adding a shutdown function in

[cedricpradalier]

This PR adds a shutdown function in network bridge, to be called between the end of spin and the shared pointer reset. The shared_from_this objects in network_bridge seem to prevent the garbage collector to start at the right moment.

Also added a try-catch in udp_bridge for a clean exit when the connection has been closed before the object is destroyed.

[cedricpradalier]

This should fix #2 as far as I can see.

[brow1633]

These code formatting tools are really starting to drive me crazy.

[brow1633]

Wow, that's hilarious, the two distributions are configured to uncrustify differently. It's not even possible to get them all to pass with a comment like this.

Let me see if I can configure uncrustify to be consistent...

[cedricpradalier]

Sorry for the white space annoyance. The linter settings is not the way I code, and ament_uncrustify did not search for files recursively, so I kept missing white spaces to fix.
I contributed to https://github.com/ros-drivers/phidgets_drivers, and they have a nice "lint-on-commit" workflow which was really nice to work with.

[brow1633]

Sorry for the white space annoyance. The linter settings is not the way I code, and ament_uncrustify did not search for files recursively, so I kept missing white spaces to fix. I contributed to https://github.com/ros-drivers/phidgets_drivers, and they have a nice "lint-on-commit" workflow which was really nice to work with.

Thanks for the reference, I'll look into it!

[cedricpradalier]

It's becoming harder to make the linter happy than to fix bad pointers... not sure I approve this evolution.