Compiling on Kilted #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tried to fix class loader unloading warning (Kilted) in network_bridge.cpp
Collaborator
Author
|
I don't know why all the commits are still listed (I tried to rebase/merge/sync). I hope this is not an issue. |
Owner
|
I'm sorry, I think this happened because I accidentally squashed the commits of your PR, so they technically don't exist on this main branch. I'll add you as reviewer to new PR. Let me know if I grabbed this change correctly. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello (again),
Here is a minor CMake change to compile without warning on kilted, because ament_target_dependency has been deprecated.
It still compiles on humble without warning. I did not test on other distros.
There is a minor fix to try to remove the class unload warning, but this did not fix it. I leave it because it is still better to stop the timer before closing the node.