Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squashing GHA bugs with error handling #1514

Merged
merged 6 commits into from
Feb 21, 2025
Merged

Conversation

nikellepetrillo
Copy link
Contributor

@nikellepetrillo nikellepetrillo commented Feb 20, 2025

Description

We were not capturing errors and surfacing them in the "Create new method configuration" and "Update test inputs, Upload to Terra, Submit, Monitor and Retrieve Outputs" step. Previously, jobs would fail to create method configs or fail to submit jobs, but the logs would appear as if it was successful. This PR adds error handling to those steps.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@nikellepetrillo nikellepetrillo changed the title handle errors during submitting jobs Squashing GHA bugs with error handling Feb 20, 2025
Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link
Member

@jessicaway jessicaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@nikellepetrillo nikellepetrillo changed the base branch from develop to np_address_gha_bugs_1 February 20, 2025 20:50
@nikellepetrillo nikellepetrillo changed the base branch from np_address_gha_bugs_1 to develop February 20, 2025 20:51
@nikellepetrillo nikellepetrillo merged commit d0e5cb7 into develop Feb 21, 2025
32 checks passed
@nikellepetrillo nikellepetrillo deleted the np_address_gha_bugs branch February 21, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants