Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving the sleep in gha framework #1511

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

nikellepetrillo
Copy link
Contributor

@nikellepetrillo nikellepetrillo commented Feb 18, 2025

Description

We need to move the 'delay' portion of the code higher up in the workflow to account for the time it takes for Dockstore to recognize a newly pushed branch. Right now, the delay isn't happening early enough, which causes issues with branch detection.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@nikellepetrillo nikellepetrillo merged commit 4a76f68 into develop Feb 19, 2025
32 checks passed
@nikellepetrillo nikellepetrillo deleted the np_moving_sleep_gha branch February 19, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants