-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCP Batch-friendly Cromwell root detection [VS-1532] (#9069) #9102
base: rwb_echo_release
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a few errors along the line of:
This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3
Is this a concern?
CROMWELL_ROOT=/cromwell_root | ||
elif [[ -e /mnt/disks/cromwell_root/gcs_delocalization.sh ]] | ||
then | ||
CROMWELL_ROOT=/mnt/disks/cromwell_root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that AoU uses individual instances of Cromwell instead of Terra's central instance. Does this assignment account for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code should be fine to run on GCP Batch or PAPI regardless of where the Cromwell instance is deployed.
But you will need to update the configs for your Cromwells to point to GCP Batch. Did the Cromwell team help you with this before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also upgrade your version of Cromwell to get all the GCP Batch fixes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They may have, but this is the first time that I have dealt with this, so I will look into it.
Thanks for your help with all this!
Probably not but easy enough to pick over the commit that fixes that too... |
AoU RWB Echo version of a GCP Batch compatibility fix already on ah_var_store.