-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAGEN Joint Detection DO NOT MERGE #8616
Open
davidbenjamin
wants to merge
51
commits into
master
Choose a base branch
from
db_dragen_joint_detection
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ange to PD haplotypes yet
…ed parts of PD haplotypes
… of PD haplotypes
…rmined event groups, determined sets etc
…etermined and undetermined, but tests are failing since I haven't updated genotyping
…T overlap the determined span
…he pre-joint detection PD haplotypes with just one determined event
…st ref-only haplotypes
… in the QUALS maybe from GL to PL conversion
…ele-genotype posteriors
…y 30, sometimes exactly so, which I think is due to double jeopardy of applying the prior
…ems to work correctly.
…to joint detection
Here is the functional equivalence report for this branch. It is slighlty less functionally-equivalent than the GATK master branch. |
@eitanbanks @droazen @jamesemery @ldgauthier Shelving this pending guidance on implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of DRAGEN joint detection. Functional equivalence with respect to DRAGEN joint detection is actually worse than before due to many outstanding questions.
We currently have no idea how joint detection is supposed to interaction with BQD and FRD. I have tried a few guesses and none have worked (see below for functional equivalence results of the particular guess used in this PR). The interplay of joint detection with BQD and FRD is complicated for several reasons.
Naively one would simply define the BDQ and FRD likelihoods on entire haplotypes rather than alleles at one locus. Unresolved difficulties with this include:
Clearly, generalizing BQD and FRD to entire haplotypes is not straightforward. Nor does it suffice to produce "raw" genotype likelihoods using the joint detection approach and then apply BQD and FRD on variant loci afterwards. Some difficulties with this include: