Added the option to supply multiple mask files to VariantFiltration #8237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the
--mask
and-mask-name
arguments to be lists so it's possible to supply multiple mask files. There are still some questions to discuss that may warrant changes:-filter-not-in-mask
also be a list, so the user specifies whether to do a mask or reverse mask for each file?a. My inclination is no, since that would make things kind of complicated and probably you just want to filter variants that appear in none of the mask files
maskName
default to now?a. Previously, it defaulted to "Mask".
b. I changed it to default to "Mask" for the first mask, and then "Mask2", "Mask3", etc. Not sure if this is ideal?
a. i.e.
mask
->masks
andmaskName
->maskNames
b. Obviously the arguments would keep the same names
-filter-not-in-mask
, what should we list for filters?a. All the mask names? (this is what I'm doing now, but it could obviously get very long and maybe be misleading?)
b. Should we just allow one
-maskName
if-filter-not-in-mask
is specified?Closes #8119