-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDO-3517: cutover Data Repo to ESO #261
Open
katiewelch
wants to merge
9
commits into
master
Choose a base branch
from
DDO-3517-cutover-datarepo-to-eso-datarepo-helm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em-may
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
godspeed
snf2ye
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 5th of 5 PRs to migrate data repo to ESO from Vault. This PR and DDO-3517 in terra-helmfile will cutover data repo to use ESO rather than Vault.
This PR removes the functionality of parsing and creating secrets from Vault from the data repo chart. At this point (due to the terra-helmfile PR), there will already be no Vault secrets in datarepo and it will be using ESO.
This repo (datarepo-helm) will hold the create-secret-manager-secret chart while terra-helmfile will hold the values.
This PR was tested by using the datarepo-helm-definitions repo. Using Olivia's setup, I pointed the chart to my local updated version of the create-secret-manager-secrets chart, after updating the values file in the definitions repos. I also pointed the values to my local versions of the terra-helmfile values files for dev, staging, prod, and BEEs.
helmfile.yaml:
After running
helmfile apply
, for each iteration of my local chart and values files, I confirmed the output matches what I expect.