Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDO-3517: cutover Data Repo to ESO #261

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

katiewelch
Copy link
Contributor

@katiewelch katiewelch commented Mar 22, 2024

This is the 5th of 5 PRs to migrate data repo to ESO from Vault. This PR and DDO-3517 in terra-helmfile will cutover data repo to use ESO rather than Vault.

This PR removes the functionality of parsing and creating secrets from Vault from the data repo chart. At this point (due to the terra-helmfile PR), there will already be no Vault secrets in datarepo and it will be using ESO.

This repo (datarepo-helm) will hold the create-secret-manager-secret chart while terra-helmfile will hold the values.

This PR was tested by using the datarepo-helm-definitions repo. Using Olivia's setup, I pointed the chart to my local updated version of the create-secret-manager-secrets chart, after updating the values file in the definitions repos. I also pointed the values to my local versions of the terra-helmfile values files for dev, staging, prod, and BEEs.

helmfile.yaml:

# helm releases to be deployed
releases:
  - name: ok-jade-create-secret-manager-secret    # release name
    namespace: ok   # target namespace
    createNamespace: true
    #chart: datarepo-helm/create-secret-manager-secret   # chart name    
    chart: /Users/welchkat/Documents/src/datarepo-helm/charts/create-secret-manager-secret   # chart name
    missingFileHandler: Warn
    values:
      #- create-secret-manager-secret.yaml      # Value files passed via --values
      - /Users/welchkat/Documents/src/terra-helmfile/values/app/datarepo/live/dev.yaml

After running helmfile apply, for each iteration of my local chart and values files, I confirmed the output matches what I expect.

@katiewelch katiewelch changed the base branch from master to DDO-3517-add-eso-to-tdr March 22, 2024 20:45
Base automatically changed from DDO-3517-add-eso-to-tdr to master April 2, 2024 15:43
Copy link

@em-may em-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godspeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants