Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1409 Java 17 #7342

Merged
merged 17 commits into from
Dec 14, 2023
Prev Previous commit
Next Next commit
Final touches
aednichols committed Dec 12, 2023
commit 2e83fe92e1654eafa8072aefd0f27c41818c6661
8 changes: 4 additions & 4 deletions .github/set_up_cromwell_action/action.yml
Original file line number Diff line number Diff line change
@@ -11,10 +11,10 @@ runs:
using: "composite" # <-- this allows these steps to be used by other workflows.
steps:
#Allows this github action to use a cache to store stuff like Java and sbt files between runs.
# - uses: actions/checkout@v3
# name: Checkout Coursier Cache
# - uses: coursier/cache-action@v6
# name: Enable Coursier Cache
- uses: actions/checkout@v3
name: Checkout Coursier Cache
- uses: coursier/cache-action@v6
name: Enable Coursier Cache

#Cromwell requires git-secrets be setup. Here, we set up secrets and verify success with a script.
- name: Git secrets setup
14 changes: 7 additions & 7 deletions .github/workflows/integration_tests.yml
Original file line number Diff line number Diff line change
@@ -105,13 +105,13 @@ jobs:
echo Running test.sh
./src/ci/bin/test.sh
# If a build step fails, activate SSH and idle for 30 minutes
- name: Setup tmate session
if: ${{ failure() }}
uses: mxschmitt/action-tmate@v3
timeout-minutes: 30
with:
limit-access-to-actor: true
detached: true
# - name: Setup tmate session
# if: ${{ failure() }}
# uses: mxschmitt/action-tmate@v3
# timeout-minutes: 60
# with:
# limit-access-to-actor: true
# detached: true
# always() is some github magic that forces the following step to run, even when the previous fails.
# Without it, the if statement won't be evaluated on a test failure.
- uses: ravsamhq/notify-slack-action@v2
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Cromwell Change Log

## 87 Release Notes

### Java 17

As of this version, a distribution of Java 17 is required to run Cromwell. Cromwell is developed, tested, and
containerized using [Eclipse Temurin](https://adoptium.net/temurin/releases/?version=17).

## 86 Release Notes

### GCP Batch
4 changes: 2 additions & 2 deletions docs/Releases.md
Original file line number Diff line number Diff line change
@@ -19,8 +19,8 @@ Mac users with Homebrew can also get Cromwell with the command `brew install cro
This documentation frequently refers to a "Cromwell jar" with a name like `cromwell-<version>.jar`.
This is the main artifact in Cromwell releases that contains all executable Cromwell code and default configuration.

A distribution of Java 11 is required to run Cromwell. Cromwell is developed, tested, and containerized using
[AdoptOpenJDK 11 HotSpot](https://adoptopenjdk.net/).
A distribution of Java 17 is required to run Cromwell. Cromwell is developed, tested, and containerized using
[AdoptOpenJDK 17 HotSpot](https://adoptopenjdk.net/).

For users running a Cromwell server [a docker image](https://hub.docker.com/r/broadinstitute/cromwell) has been made available.

4 changes: 2 additions & 2 deletions docs/tutorials/FiveMinuteIntro.md
Original file line number Diff line number Diff line change
@@ -3,11 +3,11 @@
### Prerequisites:

* A Unix-based operating system (yes, that includes Mac!)
* A Java 11 runtime environment
* A Java 17 runtime environment
* You can see what you have by running `$ java -version` on a terminal.
* If not, consider installing via conda or brew [as explained here](../Releases.md).
* We recommend [SDKMAN](https://sdkman.io/install) to install the latest 17 build of [Temurin](https://adoptium.net/temurin/releases/?version=17)
* `sdk install java 11.0.16-tem` as of the time of this writing
* `sdk install 17.0.9-tem` as of the time of this writing
* You might need to update the `export JAVA_HOME` in your bash profile to point to your JAVA install location.
* A sense of adventure!