Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't exit if ssh server failed to start #6772

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: don't exit if ssh server failed to start #6772

wants to merge 2 commits into from

Conversation

ovesh
Copy link

@ovesh ovesh commented May 27, 2022

fixes #6771

@kshakir
Copy link
Contributor

kshakir commented Jun 17, 2022

If this really does fix #6771, maybe one proves it works a CI test? Have folks talked about reverting #6728 in this PR?

@aednichols
Copy link
Collaborator

That's a great idea, just cherry-pick the commit onto this branch.

@ovesh
Copy link
Author

ovesh commented Jul 12, 2022

just cherry-pick the commit onto this branch.

I'm going to revert commit 06eb982 in this PR as suggested. I think that's what you meant, rather than cherry-picking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GCP: Ignore error if ssh-server fails
3 participants
@ovesh @kshakir @aednichols