Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CROM-6915 Copied a way to auth to GAR/GCR from PAPI to SFS. Tests TODO. #6742

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CROM-6915 Copied a way to auth to GAR/GCR from PAPI to SFS. Tests TODO. #6742

wants to merge 1 commit into from
+82 −4

Conversation

kshakir
Copy link
Contributor

@kshakir kshakir commented Apr 25, 2022

No description provided.

@kshakir
Copy link
Contributor Author

kshakir commented Apr 25, 2022

Currently only a draft since I'd like to hear from others:

  • how deeply folks want this CI tested (is a unit test using mock auth enough?)
  • if folks think this copied code should be moved down into the standard backends, since GAR/GAR can be public-but-authenticated just like DockerHub, Quay, etc

@kshakir kshakir force-pushed the ks_docker_soft_link branch 2 times, most recently from e4fac8a to d341b0f Compare May 10, 2024 18:32
Base automatically changed from ks_docker_soft_link to develop May 10, 2024 22:06
@kshakir kshakir force-pushed the ks_google_registry_sfs_auth branch from 0eadb17 to ff196b1 Compare May 10, 2024 23:22
@kshakir kshakir changed the title Copied a way to auth to GAR/GCR from PAPI to SFS. Tests TODO. CROM-6915 Copied a way to auth to GAR/GCR from PAPI to SFS. Tests TODO. May 10, 2024
@kshakir kshakir marked this pull request as ready for review May 11, 2024 06:17
@kshakir kshakir requested a review from a team as a code owner May 11, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kshakir