[AWS] Exit job with same exit code as rc file #6199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markjschreiber
approved these changes
Feb 26, 2021
…ception type other than CentaurTestException [BT-145] (broadinstitute#6197)
…l into aws/exit_rc_file
…l into aws/exit_rc_file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the current implementation of AWS backend, if there are no files to delocalize, AWS Batch will see the task as succeeded, even if it something fails on the command script. So, in the worst case, it can happen that for cromwell the task failed and for AWS Batch it succeeded.
With this change that I propose, after the delocalization process, we will exit the script with the same exit code as the one written on rc file.