Skip to content

Commit

Permalink
Remove unused config
Browse files Browse the repository at this point in the history
  • Loading branch information
jgainerdewar committed Nov 1, 2024
1 parent 32685d1 commit 71dd01d
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ case class GcpBatchConfigurationAttributes(
project: String,
computeServiceAccount: String,
auths: GcpBatchAuths,
restrictMetadataAccess: Boolean,
dockerhubToken: String,
enableFuse: Boolean,
executionBucket: String,
Expand Down Expand Up @@ -327,7 +326,6 @@ object GcpBatchConfigurationAttributes extends GcpBatchReferenceFilesMappingOper
project = project,
computeServiceAccount = computeServiceAccount,
auths = GcpBatchAuths(batchAuth, gcsAuth),
restrictMetadataAccess = restrictMetadata,
dockerhubToken = dockerhubToken,
enableFuse = enableFuse,
executionBucket = bucket,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class GcpBatchBackendLifecycleActorFactorySpec extends AnyFlatSpecLike with Matc
project = "project",
computeServiceAccount = "computeServiceAccount",
auths = null,
restrictMetadataAccess = true,
dockerhubToken = "test",
enableFuse = true,
executionBucket = "executionBucket",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,6 @@ class BatchBackendCacheHitCopyingActorSpec
project = null,
computeServiceAccount = null,
auths = null,
restrictMetadataAccess = false,
dockerhubToken = null,
enableFuse = false,
executionBucket = null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class GcpBatchConfigurationAttributesSpec
gcpBatchAttributes.executionBucket should be("gs://myBucket")
gcpBatchAttributes.maxPollingInterval should be(600)
gcpBatchAttributes.computeServiceAccount should be("default")
gcpBatchAttributes.restrictMetadataAccess should be(false)
gcpBatchAttributes.referenceFileToDiskImageMappingOpt.isEmpty should be(true)
gcpBatchAttributes.logsPolicy should be(GcpBatchLogsPolicy.CloudLogging)
}
Expand Down Expand Up @@ -112,15 +111,6 @@ class GcpBatchConfigurationAttributesSpec
gcpBatchAttributes.computeServiceAccount should be("testing")
}

it should "parse restrict-metadata-access" in {

val backendConfig = ConfigFactory.parseString(configString(batch = "restrict-metadata-access = true"))

val gcpBatchAttributes = GcpBatchConfigurationAttributes(googleConfig, backendConfig, "batch")
gcpBatchAttributes.restrictMetadataAccess should be(true)

}

it should "parse localization-attempts" in {

val backendConfig = ConfigFactory.parseString(configString(batch = "localization-attempts = 31380"))
Expand Down

0 comments on commit 71dd01d

Please sign in to comment.