Fix more instances of SQLite "too many variables" errors #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a failure that cropped up in the
brioche-packagesrepo (e.g. in CI #148) with the following error message:I was able to reproduce locally by moving my
~/.local/share/briochedirectory somewhere else then runningbrioche build -p ./packages/nushell. This resulted too many SQLite variables being used in a single query (the limit is either 999 or 32,766 depending on the SQLite version)The fix in this PR is simple: batch the query to limit the max number of records fetched / inserted per query, thereby limiting the number of SQLite variables used