Improve project analysis #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sync versions are specifically needed because the TypeScript Language Service expects functions like `read_file` to be sync. This can be resolved by reading all the files ahead-of-time, which can be done as a follow-up
This command mainly exists for testing
`CompilerHost` can now load a file, which loads it and all its imports (recursively) into the list of documents. Reading a document now only blocks on the `RwLock`, and never does I/O
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls the "project analysis" phase to find all imported file paths ahead-of-time. This doesn't have much impact on functionality, but it will be important for things like "format all files in this project".
One outcome of this PR that is an improvement though: the TypeScript Language Service Host no longer does blocking I/O to read files! 🎉 This is because we now asynchronously load documents into the
BriocheCompilerHosttype before calling into the TypeScript code. Then, the TypeScript code uses Deno ops that just read fromBriocheCompilerHost, and assume that the documents have already been loaded asynchronously.There are still some instances of blocking I/O-- namely when resolving import specifiers-- but it'll take some more work to fix those cases.