add etckeeper {pre,post}run_commands to generated puppet.conf #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows automatic integration with the etckeeper system, if it is present and configured. AFAIK this is the only way available to track /etc changes pre/post a puppet apply run; but even if not it's very common and useful :) The etckeeper scripts are supplied (and enabled by default) by the ubuntu puppet-common package.
|
Hi, thanks for the patch. sorry for the delay in responding! this is neat, but I'm wondering how it'll affect people not using etckeeper. Will puppet fail to run? I think puppet-git-receiver should support non-ubuntu/debian package installs of puppet so we can't assume it's the etckeeper is installed. Should we have puppet-git-receiver check to see it's installed before adding it to the config? Does it need configuring? Or perhaps just have a git option to enable it (and have it disabled by default) and document it? I'm worried about risking breaking the script in some circumstances to benefit the minority of users who use etckeeper. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows automatic integration with the etckeeper system, if it is
present and configured. AFAIK this is the easiest way available to track /etc
changes pre/post a puppet apply run; but even if not it's very common and
useful :)
The etckeeper scripts are supplied (and enabled by default) by the ubuntu
puppet-common package.