remember last workspace visited by user #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieiralucas
force-pushed
the
remember-user-workspace
branch
from
6aa5489
to
feaba15
Compare
lucasfcosta
reviewed
Nov 29, 2024
| workspaces.data.find((workspace) => workspace.ownerId === user.id) ?? | ||
| workspaces.data[0] | ||
| if (workspace) { | ||
| router.replace(`/workspaces/${workspaces.data[0].id}/documents`) |
There was a problem hiding this comment.
Can't workspaces.data[0] be undefined, technically speaking? Shouldn't we have kept that length check above?
There was a problem hiding this comment.
This is a bug, it should use workspace.id
Comment on lines
+17
to
+22
| const workspace = | ||
| data.find( | ||
| (workspace) => workspace.id === session.data?.lastVisitedWorkspaceId | ||
| ) ?? | ||
| data.find((workspace) => workspace.ownerId === session.data?.id) ?? | ||
| data[0] |
There was a problem hiding this comment.
Probably not something for this PR, but it's kind of annoying that we have to have very similar code here and in the session redirect.
Comment on lines
+2
to
+5
| ALTER TABLE "User" ADD COLUMN "lastVisitedWorkspaceId" UUID; | ||
|
|
||
| -- AddForeignKey | ||
| ALTER TABLE "User" ADD CONSTRAINT "User_lastVisitedWorkspaceId_fkey" FOREIGN KEY ("lastVisitedWorkspaceId") REFERENCES "Workspace"("id") ON DELETE SET NULL ON UPDATE CASCADE; |
There was a problem hiding this comment.
Can we make this migration set the first value of lastVisitedWorkspaceId as the latest workspace this user created? If that doesn't exist, we could just set it to the earliest workspace.
There was a problem hiding this comment.
The source code will default to one he is owner of
vieiralucas
force-pushed
the
remember-user-workspace
branch
from
feaba15
to
c3f09f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.