feat: Introduce ALLOW_HTTP env var that allows authentication to work without https #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieiralucas
force-pushed
the
allow-http
branch
from
0815d34 to
5a9fab9
Compare
vieiralucas
force-pushed
the
allow-http
branch
from
5a9fab9 to
3ecaaad
Compare
lucasfcosta
reviewed
Sep 12, 2024
Co-authored-by: Lucas da Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
Notice that this is also removing the
sessionExpirycookie because it needsTLDto be set which defeats the idea of running Briefer without a domain.The drawback of removing that is minor, it is only used at the frontend to know when the
tokenis expired and move user back to login screen automatically. We should implement that using another strategy.