Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix breaking editor when switching pages while there's a diff in a page #235

Merged
merged 1 commit into from
Nov 12, 2024
Merged

fix breaking editor when switching pages while there's a diff in a page #235

merged 1 commit into from
Nov 12, 2024

Conversation

lucasfcosta
Copy link
Member

Close #172
Close #204

Note that #204 was actually #172

@vieiralucas
Copy link
Member

thanks codemirror for accepting any when it actually breaks when you give null

@vieiralucas vieiralucas merged commit 6e4c76c into main Nov 12, 2024
2 checks passed
@vieiralucas vieiralucas deleted the fix-diff-editor-crashing-on-page-switch branch November 12, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@lucasfcosta @vieiralucas