closes issue 136#242
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@yesi3 is attempting to deploy a commit to the aminubabafatima8-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yesi3 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@yesi3 Please fix CI |
Contributor
|
My CI is designed to protect deployment. You cannot edit it or any sensitive/configuration The vercel build will catch it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
Adds Playwright end-to-end testing for the Bridgelet reference UI. Installs @playwright/test, adds a base config targeting http://localhost:3000, introduces a smoke E2E suite, wires test:e2e / test:e2e:ui npm scripts, and updates Frontend CI to run E2E against the built Next.js app (next build then next start). Documentation in TESTING.md, E2E guidelines, frontend README, and CHANGELOG is updated to match.
Linked Issues & References
Issue: Resolves #136
Related PRs: N/A
Type of Change
Category
New Feature (Non-breaking change adding functionality)
Bug Fix (Non-breaking change fixing an issue)
Performance Optimization (Code change to improve efficiency)
Refactoring (Code structure change without external API modification)
Security Patch (Fixing a vulnerability or security concern)
Documentation (Updates to README, Wiki, or inline docs)
Infrastructure (CI/CD, build scripts, Docker)
Domain
Smart Contracts (Rust/Soroban)
SDK/Backend (NestJS/TypeScript)
Frontend/UI
Technical Implementation Details
Added @playwright/test and frontend/playwright.config.ts with baseURL: http://localhost:3000
Local runs use npm run dev (or reuse an existing server); CI (CI=true) uses npm run start after npm run build
Smoke specs in frontend/e2e/ cover homepage load, navigation to /send and /claim/example-token, and send-page render
Frontend CI (.github/workflows/frontend-ci.yml) installs Chromium, runs npm run test:e2e, and uploads the Playwright report on failure
Docs updated: TESTING.md, docs/testing/E2E_GUIDELINES.md, frontend/README.md, CHANGELOG.md
Breaking Changes
No - Backward compatibility is maintained.
Yes - This change requires consumers of the SDK/Contract to update their code.
Verification & Testing Strategy
Automated Tests
Unit Tests: Added/Updated new unit tests.
Integration Tests: Verified interaction between modules.
Linting: Code follows the project's style guide.
Manual Verification
Target Environment: Local Next.js app on http://localhost:3000 (dev server via Playwright webServer)
2. Reproduction Steps:
cd frontend && npx playwright install --with-deps chromium
npm run test:e2e
Confirm all smoke specs pass (optionally npm run build && CI=true npm run test:e2e to mirror CI)
3. Proof of Execution: Chromium installed successfully. Playwright reported 4 passed (18.0s) for e2e/home.spec.ts and e2e/send.spec.ts. Production npm run build also succeeded locally before commit.
Quality Assurance Checklist
I have performed a self-review of my own code.
I have commented on my code, particularly in hard-to-understand areas.
I have updated the documentation to reflect these changes.
My changes do not generate new warnings or errors.
I have verified that new dependencies are necessary and secure.
(If Smart Contract) I have verified gas usage and storage footprints are optimized.
By submitting this Pull Request, I acknowledge that I have adhered to the Bridgelet contribution guidelines.